Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CEA Auth changes #2483

Merged
merged 21 commits into from
Oct 3, 2024
Merged

CEA Auth changes #2483

merged 21 commits into from
Oct 3, 2024

Conversation

lakhveerk
Copy link
Contributor

@lakhveerk lakhveerk commented Aug 26, 2024

For more information about how to contribute to this repo, visit this page.

Description

Adding support for ExternalAppAuthenticationForCEA. This is a new capability available only for MChat to call in cases the thrid party app is backed with Custom Engine Agent.
The ExternalAppAuthenticationForCEA APIs work similar to ME APIs AuthenticateAndResendRequest and AuthenticateWIthSSOAndResendRequest that exist in ExternalAppAuthentication capability. The few differences are

  1. There are two more APIs, AuthenticateWithSSO and AuthenticateWithOauth. The purpose of each API can be read in externalAppAuthenticationForCEA.ts file.
  2. CEA APIs take coversationId along with other parameters
  3. CEA takes AppId object instead of string type

If this Pull Request should close/resolve any issues when merged, use the special syntax for that here.

Main changes in the PR:

  1. Added ExternalAppAuthenticationForCEA capability to teamsjs
  2. Added corresponding test app changes
  3. Added e2e test file

Validation

Validation performed:

  1. <Step 1>
  2. <Step 2>

Unit Tests added:

Unit tests are required for all changes. If no unit tests were added as part of this change, please explain why they aren't necessary.

<Yes/No>

End-to-end tests added:

<Yes/No>

Additional Requirements

Change file added:

Ensure the change file meets the formatting requirements.

<Yes/No>

Related PRs:

Remove this section if n/a

Next/remaining steps:

List the next or remaining steps in implementing the overall feature in subsequent PRs (or is the feature 100% complete after this?).

Remove this section if n/a

  • Item 1
  • Item 2

Screenshots:

Remove this section if n/a

Before After
< image1 > < image2 >

Copy link
Contributor

This pull request contains changes to the runtime.ts file. If you, as the author of this PR, have made changes to the Runtime interface please review RUNTIME.md to determine if a new runtime version is required. Please reply to this comment stating what changes, if any, were made to the runtime object and whether a new runtime version was required.

@lakhveerk lakhveerk marked this pull request as ready for review October 2, 2024 00:22
@lakhveerk lakhveerk requested a review from a team as a code owner October 2, 2024 00:22
@lakhveerk lakhveerk changed the title CEC Auth changes CEA Auth changes Oct 2, 2024
Copy link
Contributor

@AE-MS AE-MS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

Copy link
Contributor

@AE-MS AE-MS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for incorporating my feedback; I've left one new comment.

@lakhveerk lakhveerk requested a review from AE-MS October 3, 2024 01:23
Copy link
Contributor

@AE-MS AE-MS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@lakhveerk lakhveerk enabled auto-merge (squash) October 3, 2024 01:26
@lakhveerk lakhveerk merged commit d7f13c7 into main Oct 3, 2024
29 checks passed
@lakhveerk lakhveerk deleted the lakhveer/cecAuth branch October 3, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants